fix(folly): Replace __type_pack_element in ForeachTest.cpp for GCC 14 Compatibility #2499
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port GCC 14 The use of the `__type_pack_element` compiler builtin directly in function signatures in `folly/container/test/ForeachTest.cpp` causes a build failure with GCC 14. This is because the builtin is not intended for use in contexts that affect name mangling. This commit resolves the issue by replacing the direct usage of `__type_pack_element_t` with `std::tuple_element_t`. This is a standards-compliant library trait that provides the same functionality and is safe to use in function signatures. This change ensures that `ForeachTest` continues to compile successfully with newer versions of GCC, maintaining compiler compatibility. Signed-off-by: lyd1992 <[email protected]> Signed-off-by: ihb2032 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a build failure in folly/container/test/ForeachTest.cpp when compiling with GCC 14. The error is due to the use of the compiler builtin __type_pack_element in function signatures, which is no longer permitted.
The fix replaces the problematic use of type_pack_element_t with the standard library equivalent, std::tuple_element_t. This change ensures that the test suite remains compatible with the latest compiler versions without altering the logic of the tests.