Improve ToastAndroid jsdocs #48779
Closed
Improve ToastAndroid jsdocs #48779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
|
@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@Abbondanzo merged this pull request in 299a7a9. |
gabrieldonadel
pushed a commit
to gabrieldonadel/react-native
that referenced
this pull request
Aug 12, 2025
Summary: Was looking into improving some of the type definitions for the `ToastAndroid` component and found out also that some of the options don't work anymore from API 30 – I revamped a bit these definitions to reflect that as I saw questions about it online. These updates could also be added to the website later. ## Changelog: [GENERAL][CHANGED] - Improve ToastAndroid jsdocs Pull Request resolved: facebook#48779 Test Plan: Check the jsdocs look good when using the `ToastAndroid` component in the code. Reviewed By: cortinico Differential Revision: D68393949 Pulled By: Abbondanzo fbshipit-source-id: 4be318062483db5be3825b7b21f540030f6c5b10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Was looking into improving some of the type definitions for the
ToastAndroidcomponent and found out also that some of the options don't work anymore from API 30 – I revamped a bit these definitions to reflect that as I saw questions about it online. These updates could also be added to the website later.Changelog:
[GENERAL][CHANGED] - Improve ToastAndroid jsdocs
Test Plan:
Check the jsdocs look good when using the
ToastAndroidcomponent in the code.