[DRAFT] Disable auto-recovery for some WAL write IO error; Re-enable track_and_verify_wals in crash test #13903
+28
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hx235
force-pushed
the
debug_track_verify_wal_error
branch
from
70bb732 to
53ad5c8
Compare
hx235
changed the title
hx235
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized there are more tests that assume auto-recovery ability of WAL write IO error. I need to think more about this and wonder why the previous stress test didn't fail much with the CF inconsistency.
Context/Summary:
When
atomic_flush = falsewith multiple column families, when encountering WAL related IO error, individual CF flushing during auto recovery can create data inconsistencies (caught by track_and_verify_wals=1) where some column families advance past the corruption point while others remain behind, preventing successful database restart. Therefore we disable auto recovery by setting a higher severityStatus::Severity::kFatalErrorand such testing combination in db crash test.This PR also fixes a bug in stress test that we considered
Status::Severity::kFatalErroras retryable.Test plan: