L2pullbacks #1463
Merged
L2pullbacks #1463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2019
Closed
dham
reviewed
Jun 27, 2019
dham
previously approved these changes
Jun 27, 2019
|
I've opened the UFL PR: https://bitbucket.org/fenics-project/ufl/pull-requests/114 |
|
The two PRs this depends on are already merged. |
|
I just squashed everything, let's see that it runs against current master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds proper L2 pullbacks (ie integral-preserving, designed for n-forms), by defining new elements at the UFL level and introducing an "L2 Piola" mapping. These elements then share the same FIAT/FiNAT classes as the original elements, since from the perspective of the tabulator the pullback doesn't matter.
Requires firedrakeproject/tsfc#194 and FEniCS/ufl#4.