Skip to content

Conversation

12fahed
Copy link

@12fahed 12fahed commented Sep 6, 2025

Fixed the Contributor.md format where there were errors regarding the beginning of each line

Before submitting this pull request, check the changes to see it's only the changes you made intentionally
If there are changes to other lines you didn't make deliberately, it's possible that your IDE made the changes with a utility like prettier.
Next time, make sure that you only add your changes by using git add -p and rather than git add Contributors.md

If you're doing something in the checklist below, put an x inside [ ] so that - [ ] becomes - [x]

  • I had fun going through this tutorial (ノ^o^)ノ and learned on the way ٩(^◡^)۶
    There are some things I'd like to improve in this tutorial. I have written them below.
    There were steps where I had errors while following this tutorial. I have written them below.

Copy link
Member

@Roshanjossey Roshanjossey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! You've successfully submitted a pull request. 🎉 🥳 🎊
Unfortunately, we can't merge and have to close this pull request because of merge conflicts.
If you really wanted to make these changes, please read design decisions

If you didn't make changes to other lines deliberately, it's possible that your IDE made the changes with a utility like prettier. Next time, make sure that you only add your changes by using 'git add -p' and rather than 'git add Contributors.md'

Feel free to ask me any questions if you need further clarifications :)

Cheers

If you're interested in trying this again 🚀, please try adding your entry somewhere in the middle of Contributors.md.
Also, please don't change other lines as it could cause merge conflicts. 👍

@12fahed
Copy link
Author

12fahed commented Sep 7, 2025

Thank you for the reply.
Well i was going though the contributor.md where i found that the list wasnt following the markdown properly, so thought of changing it writing a python script which ensures the data integrity and just had changed the format. But still if this was the reason of not merging my PR then i will take care of it next time, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants