Skip to content

fix: add bottom margin overflow in hastags of event-cards #5289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 14, 2020
Merged

fix: add bottom margin overflow in hastags of event-cards #5289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c9e32e
added bottom margin and prevent overflow of hastags in event-cards
ShreyanshSrivastava Oct 11, 2020
5938a85
prevented the text overflow and layout issues in grid
ShreyanshSrivastava Oct 11, 2020
b78c586
added class and removed complicated selector
ShreyanshSrivastava Oct 13, 2020
255a52b
Merge branch 'development' into event-cards-margin-bottom
ShreyanshSrivastava Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion app/styles/partials/event-card.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.event.card {
height: 355px;
height: auto;

.header {
height: 50px;
Expand All @@ -17,6 +17,17 @@
}
}

.extra.content {

.hashtags {
display: block;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
width: 90%;
}
}

.event.wide {
border-radius: 0 !important;
margin: 0 !important;
Expand Down
2 changes: 1 addition & 1 deletion app/templates/components/event-card.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<span class="right floated">
<i role="button" class="share alternate link icon" {{action this.shareEvent this.event}}></i>
</span>
<span>
<span class="hashtags">
{{#if hasBlock}}
{{yield}}
{{else}}
Expand Down