-
Notifications
You must be signed in to change notification settings - Fork 21
feat: updated Schemas and Intents #2552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JoeCap08055
wants to merge
5
commits into
main
Choose a base branch
from
feat/schemas-permissions-development
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Goal The goal of this PR is to implement *only* the *types* and *pallet storage* for the following new on-chain entities: * Intents * IntentGroups Closes #2561 **NOTE:** No tests or benchmarks added in this PR, as it only contains types and storage, no executable runtime code (coming in a separate PR) # Checklist - [x] Updated Pallet Readme? - [ ] Updated js/api-augment for Custom RPC APIs? - [x] Design doc(s) updated? - [ ] Unit Tests added? - [ ] e2e Tests added? - [ ] Benchmarks added? - [ ] Spec version incremented? # Conflicts: # runtime/frequency/src/lib.rs
…ntGroup) (#2563) # Description This PR implments type, storage, and runtime RPCs for mapping fully qualified names of the form `<protocol>.<descriptor>` to Intents or IntentGroups. Additional tests & support will be the subject of an upcoming PR; this is only merging to a feature branch. Closes #2562 # Discussion - <!-- List discussion items --> # Checklist - [ ] Updated Pallet Readme? - [ ] Updated js/api-augment for Custom RPC APIs? - [ ] Design doc(s) updated? - [ ] Unit Tests added? - [ ] e2e Tests added? - [ ] Benchmarks added? - [ ] Spec version incremented?
b91436b
to
6307cc1
Compare
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
# Goal The goal of this PR is to implement the extrinsics, RPCs and unit tests for Intents and IntentGroups. Closes #2564 # Discussion - <!-- List discussion items --> # Checklist - [x] Updated Pallet Readme? - [ ] Updated js/api-augment for Custom RPC APIs? - [ ] Design doc(s) updated? - [x] Unit Tests added? - [ ] e2e Tests added? - [x] Benchmarks added? - [ ] Spec version incremented?
# Goal The goal of this PR is to update the types, extrinsics, and runtime APIs for the Schemas pallet to conform to the new design Closes #2580 # Checklist - [ ] Updated Pallet Readme? - [x] Updated js/api-augment for Custom RPC APIs? - [ ] Design doc(s) updated? - [ ] Unit Tests added? - [ ] e2e Tests added? - [x] Benchmarks added? - [ ] Spec version incremented? --------- Co-authored-by: Shannon Wells <[email protected]> Co-authored-by: Aramik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
metadata-changed
Metadata has changed since the latest full release
metadata-version-not-incremented
Metadata has changed since the latest full release, but the version has not been incremented
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to implement the design described here
Tracking epic: #2550
Checklist