Support pairing during activation screen #1191
Merged
+47
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the sequence number.
Our request_pairing_data() was previously assuming request/response semantics, which is incorrect.
oleavr
force-pushed
the
hsorbo/pairing
branch
from
ee611ec to
b14fdcc
Compare
|
Thanks! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pairing during IOS activation screen the flow is a bit different.
There is no
awaitingUserConsentevents emitted and this makes the sequence numbers drift breaking our assumptions that they are balanced (response seqno = request seqno).Secondly
pairingDatais not a request/response but an event and should be treated as an event.awaitingUserConsentis another event that may or may not appear after host initiated apairingDataevent and before device signal apairingDataorpairingRejectedWithErrorevent.