Merge main into releases/v3 #3102
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Mergeback v3.30.2 refs/heads/releases/v3 into main
Co-authored-by: henrymercer <[email protected]>
…336-b8b24b72dba3 Remove --intra-layer-parallelism flag from CodeQL CLI commands
This introduces a new internal environment variable flag (`CODEQL_ACTION_SARIF_DUMP_DIR`) that, when set to `true`, causes the SARIF file that will be uploaded to be dumped to the specified directory. The filename will be `upload.sarif` or `upload.quality.sarif` depending on the upload target.
Dump soon to be uploaded SARIF on request
…plate Add a reminder to the PR template that this is a public repo
…ize-limit Overlay: Increase size limit for cached overlay base database
There was a problem hiding this comment.
Pull Request Overview
This release PR merges changes from main into the releases/v3 branch to create version 3.30.3. The purpose is to prepare a new patch release with several improvements and fixes.
Key changes include:
- Added SARIF dump functionality for debugging purposes
- Updated overlay database size limits with improved documentation
- Removed deprecated
--intra-layer-parallelismflag from CodeQL queries
Reviewed Changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| CHANGELOG.md | Added release entry for version 3.30.3 |
| package.json | Version bump from 3.30.2 to 3.30.3 |
| src/upload-lib.ts | Added SARIF dump functionality for debugging |
| src/overlay-database-utils.ts | Updated size limits and improved documentation |
| src/environment.ts | Added SARIF_DUMP_DIR environment variable |
| src/codeql.ts | Removed deprecated --intra-layer-parallelism flag |
| src/codeql.test.ts | Updated test to reflect removed flag |
| .github/pull_request_template.md | Added comment header for public repository reminder |
| lib/*.js | Generated JavaScript files from TypeScript sources |
Files not reviewed (1)
- package-lock.json: Language not supported
| /** | ||
| * Dumps the given processed SARIF file contents to `outputDir`. | ||
| */ | ||
| function dumpSarifFile( | ||
| sarifPayload: string, | ||
| outputDir: string, | ||
| logger: Logger, | ||
| uploadTarget: analyses.AnalysisConfig, | ||
| ) { |
There was a problem hiding this comment.
The function documentation should specify what happens when the output directory already exists and contains files, and clarify the file naming convention. The current documentation only mentions creating the directory if it doesn't exist.
Copilot uses AI. Check for mistakes.
| const outputFile = path.resolve( | ||
| outputDir, | ||
| `upload${uploadTarget.sarifExtension}`, |
There was a problem hiding this comment.
If multiple uploads occur to the same directory, this will overwrite the previous file since the filename is always upload${uploadTarget.sarifExtension}. Consider adding a timestamp or unique identifier to prevent data loss.
| const outputFile = path.resolve( | |
| outputDir, | |
| `upload${uploadTarget.sarifExtension}`, | |
| const uniqueSuffix = `${Date.now()}-${Math.floor(Math.random() * 1e6)}`; | |
| const outputFile = path.resolve( | |
| outputDir, | |
| `upload-${uniqueSuffix}${uploadTarget.sarifExtension}`, |
Copilot uses AI. Check for mistakes.
Merging f374a62 into
releases/v3.Conductor for this PR is @cklin.
Contains the following pull requests:
Please do the following:
releases/v3branch.Create a merge commitis selected rather thanSquash and mergeorRebase and merge.