Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
fixes: https://github.com/github/docs-engineering/issues/5623
related? nodejs/node#59364
seeeems like a node problem with 22.18.0? only a problem in github/docs right now because in docs-internal i see node 22.14.0 getting installed during setup (I assume because different runners?)
my local testing with 22.17.0 vs. 22.18.0:
so same error as https://github.com/github/docs-internal/actions/runs/16891261375/job/47851347313
What's being changed (if available, include any code snippets, screenshots, or gifs):
I think this
engines
syntax works and our setup action will use it? if there's a better way to do it let me know!https://github.com/github/docs-internal/blob/e739fc93cfeb77ce3be8a60c5c46b5dbafb21dc0/.github/actions/node-npm-setup/action.yml#L22
Check off the following: