Skip to content

Conversation

rsese
Copy link
Member

@rsese rsese commented Aug 12, 2025

Why:

fixes: https://github.com/github/docs-engineering/issues/5623
related? nodejs/node#59364

seeeems like a node problem with 22.18.0? only a problem in github/docs right now because in docs-internal i see node 22.14.0 getting installed during setup (I assume because different runners?)

my local testing with 22.17.0 vs. 22.18.0:

➜  docs git:(main) nvm use 22.17.0
Now using node v22.17.0 (npm v10.9.2)
➜  docs git:(main) npm run playwright-test -- src/fixtures/tests/playwright-local-dev.spec.ts:37 

> playwright-test
> playwright test --config src/fixtures/playwright.config.ts --project="Google Chrome" src/fixtures/tests/playwright-local-dev.spec.ts:37


Running 1 test using 1 worker

  ✓  1 [Google Chrome] › src/fixtures/tests/playwright-local-dev.spec.ts:37:1 › search "foo" and get results (1.9s)
[WebServer] (node:29205) [DEP0060] DeprecationWarning: The `util._extend` API is deprecated. Please use Object.assign() instead.
[WebServer] (Use `node --trace-deprecation ...` to show where the warning was created)

  1 passed (5.7s)
➜  docs git:(main) nvm use 22.18.0                                                               
Now using node v22.18.0 (npm v10.9.3)
➜  docs git:(main) npm run playwright-test -- src/fixtures/tests/playwright-local-dev.spec.ts:37 

> playwright-test
> playwright test --config src/fixtures/playwright.config.ts --project="Google Chrome" src/fixtures/tests/playwright-local-dev.spec.ts:37

SyntaxError: The requested module '@playwright/test' does not provide an export named 'Page'
Error: No tests found.
Make sure that arguments are regular expressions matching test files.
You may need to escape symbols like "$" or "*" and quote the arguments.

so same error as https://github.com/github/docs-internal/actions/runs/16891261375/job/47851347313

What's being changed (if available, include any code snippets, screenshots, or gifs):

  • update engines to not use 22.18.0 temporarily

I think this engines syntax works and our setup action will use it? if there's a better way to do it let me know!

https://github.com/github/docs-internal/blob/e739fc93cfeb77ce3be8a60c5c46b5dbafb21dc0/.github/actions/node-npm-setup/action.yml#L22

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

@rsese rsese self-assigned this Aug 12, 2025
@Copilot Copilot AI review requested due to automatic review settings August 12, 2025 19:43
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR temporarily restricts Node.js version 22.18.0 due to a compatibility issue with Playwright tests. The change modifies the engines field in package.json to exclude the problematic version while maintaining support for Node.js 20.x and earlier 22.x versions.

  • Excludes Node.js 22.18.0 from supported versions to resolve Playwright test failures
  • Maintains compatibility with Node.js 20.x and Node.js 22.0.0 through 22.17.x

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copy link
Contributor

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

This pull request contains code changes, so we will not generate a table of review links.

🤖 This comment is automatically generated.

Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • package.json

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/**
  • package*.json
  • content/actions/how-tos/security-for-github-actions/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai or contentType: rai.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 12, 2025
@rsese rsese closed this Aug 12, 2025
@rsese
Copy link
Member Author

rsese commented Aug 12, 2025

woops, need to open internally 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant