adding hub-sync feature code #873

jefeish · 2025-08-28T01:33:11Z

This pull request introduces a new "Safe Settings Hub Sync" feature for centralized configuration management across multiple organizations.
The main changes include:

adding a hub‑and‑spoke synchronization handler,
updating environment/configuration files
introducing a new installation cache for efficient GitHub App installation lookups.
adding a dashboard ui

lib/hubSyncHandler.js

+    const directPush = (env.SAFE_SETTINGS_HUB_DIRECT_PUSH === 'true' || env.SAFE_SETTINGS_HUB_DIRECT_PUSH === '1');
+
+    // Find installation for destination org to auth
+  const installs = await getInstallations(robot)


To fix the issue, simply terminate the statement const installs = await getInstallations(robot) on line 95 with an explicit semicolon. This improves readability and consistency within the function, reduces the risk of accidents if the code is refactored, and aligns with the project's apparent style, which is to use semicolons after statements. Specifically, edit line 95 in lib/hubSyncHandler.js to add a semicolon.

lib/routes.js

+        async function run() {
+          if (i >= items.length) return
+          const idx = i++
+            const p = Promise.resolve(mapper(items[idx], idx)).then(r => { out[idx] = r; running.delete(p) })


To fix the issue, remove the superfluous second argument (idx) from the call to mapper within mapWithLimit (on line 283). The function signature being used as a callback only takes a single parameter and does not utilize further arguments, and there is no indication elsewhere in this snippet that the index is needed (nor any evidence of use of the arguments object). Thus, update line 283 to only pass items[idx] to mapper, eliminating the unused idx argument. No further code or import changes are necessary since functionality remains the same and no new features are introduced.

ui/src/app/components/EnvVariables.jsx

+
+  const copyToClipboard = (text) => {
+    try { navigator.clipboard.writeText(text); } catch(_) {}
+  }


To fix the problem and make semicolon usage completely explicit and consistent, we should add a semicolon after the closing brace of the copyToClipboard function at line 89, making it clear that this is the end of a function expression assigned to a variable. This also matches the style used for other functions in the file (such as fetchData, cycleSort, etc.), and prevents any confusion arising from relying on implicit semicolon insertion. No further imports or changes are required.

ui/src/app/components/OrganizationsTable.jsx

+import { useHydrated } from '../hooks/useHydrated';
+
+// Mock organizations used when /api/organizations returns 404
+const MOCK_ORGS = [


The correct way to fix this is simply to remove the unused variable declaration (lines 8–12 defining MOCK_ORGS). This does not impact any existing functionality, as the variable isn't referenced anywhere else in the code or used for actual rendering or fallback logic. You should remove those lines from the file ui/src/app/components/OrganizationsTable.jsx. No additional imports, method definitions, or code changes are needed.

ui/src/app/components/Safe-settings-hubContent.jsx

+import { useHydrated } from '../hooks/useHydrated';
+
+// Simple mock tree used when API returns 404 (dev convenience)
+const MOCK_TREE = {


To resolve the problem, simply remove the declaration and definition of the unused variable MOCK_TREE (lines 7–46). This consists of a single contiguous block representing the mock object. No other part of the shown file refers to MOCK_TREE, so its removal will not alter existing functionality. No imports or additional definitions are needed.

ui/src/app/components/Safe-settings-hubContent.jsx

+    });
+  }, [search, displayTree]);
+
+  const flatList = useMemo(() => {


To resolve this problem, simply delete the flatList assignment using useMemo since its result is never subsequently used in the component. This means deleting lines 179–186 as currently written. No other code modifications are required, as its removal will not affect component functionality (because it was unused).

Only remove the block that defines flatList and its memoization logic, without affecting adjacent logic or hooks. No new imports, methods, or other code changes are required.

ui/src/app/components/ThemeToggle.jsx

+import { useTheme } from './ThemeContext';
+
+export default function ThemeToggle() {
+  const { theme, toggleTheme, isDark } = useTheme();


To fix the problem, we should remove the unused theme variable from the destructuring assignment in the ThemeToggle component. This means modifying the line

const { theme, toggleTheme, isDark } = useTheme();

to exclude theme:

const { toggleTheme, isDark } = useTheme();

This change should be applied only in ui/src/app/components/ThemeToggle.jsx. No other code or imports are affected by this change.

adding hub-sync feature code

ea663c2

github-advanced-security bot found potential problems Aug 28, 2025

View reviewed changes

@@ -92,7 +92,7 @@
                 const directPush = (env.SAFE_SETTINGS_HUB_DIRECT_PUSH === 'true' || env.SAFE_SETTINGS_HUB_DIRECT_PUSH === '1');
                 // Find installation for destination org to auth
-              const installs = await getInstallations(robot)
+              const installs = await getInstallations(robot);
                 const install = installs.find(i => i.account && i.account.type === 'Organization' && i.account.login.toLowerCase() === destOwner.toLowerCase());
                 if (!install) {
                   robot.log.warn(`Installation for destination org ${destOwner} not found; cannot sync`);

@@ -280,7 +280,7 @@
                     async function run() {
                       if (i >= items.length) return
                       const idx = i++
-                        const p = Promise.resolve(mapper(items[idx], idx)).then(r => { out[idx] = r; running.delete(p) })
+                        const p = Promise.resolve(mapper(items[idx])).then(r => { out[idx] = r; running.delete(p) })
                       running.add(p)
                       if (running.size >= MAX_DIR_CONCURRENCY) await Promise.race(running)
                       return run()

@@ -86,7 +86,7 @@
               const copyToClipboard = (text) => {
                 try { navigator.clipboard.writeText(text); } catch(_) {}
-              }
+              };
               return (
                 <div className="ui-table">

@@ -5,11 +5,6 @@
             import { useHydrated } from '../hooks/useHydrated';
             // Mock organizations used when /api/organizations returns 404
-            const MOCK_ORGS = [
-              { id: 1, name: 'mock-org-one', lastSyncDate: new Date(Date.now() - 3600 * 1000).toISOString(), lastSyncMessage: 'Initial mock sync', lastSyncSha: 'abcdef1', ageSeconds: 3600 },
-              { id: 2, name: 'example-inc', lastSyncDate: new Date(Date.now() - 7200 * 1000).toISOString(), lastSyncMessage: 'Second mock sync', lastSyncSha: 'abcdef2', ageSeconds: 7200 },
-              { id: 3, name: 'demo-labs', lastSyncDate: null, lastSyncMessage: null, lastSyncSha: null, ageSeconds: null, na: true }
-            ];
             const OrganizationsTable = ({ organizations: propOrganizations = [] }) => {
               const [searchTerm, setSearchTerm] = useState('');

@@ -4,46 +4,6 @@
             import { useHydrated } from '../hooks/useHydrated';
             // Simple mock tree used when API returns 404 (dev convenience)
-            const MOCK_TREE = {
-              name: '.github',
-              path: '.github',
-              type: 'dir',
-              lastCommitAt: new Date(Date.now() - 3600 * 1000).toISOString(),
-              entries: [
-                {
-                  name: 'settings.yml',
-                  path: '.github/settings.yml',
-                  type: 'file',
-                  lastCommitAt: new Date(Date.now() - 1800 * 1000).toISOString(),
-                  lastCommitMessage: 'chore: mock settings',
-                  lastCommitSha: 'mock123'
-                },
-                {
-                  name: 'CODEOWNERS',
-                  path: '.github/CODEOWNERS',
-                  type: 'file',
-                  lastCommitAt: new Date(Date.now() - 7200 * 1000).toISOString(),
-                  lastCommitMessage: 'feat: add mock CODEOWNERS',
-                  lastCommitSha: 'mock456'
-                },
-                {
-                  name: 'workflows',
-                  path: '.github/workflows',
-                  type: 'dir',
-                  lastCommitAt: new Date(Date.now() - 5400 * 1000).toISOString(),
-                  entries: [
-                    {
-                      name: 'ci.yml',
-                      path: '.github/workflows/ci.yml',
-                      type: 'file',
-                      lastCommitAt: new Date(Date.now() - 2500 * 1000).toISOString(),
-                      lastCommitMessage: 'ci: mock workflow',
-                      lastCommitSha: 'mock789'
-                    }
-                  ]
-                }
-              ]
-            };
             export default function SafeSettingsHubContent() {
               const hydrated = useHydrated();

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

adding hub-sync feature code #873

adding hub-sync feature code #873

Uh oh!

jefeish commented Aug 28, 2025 •

edited

Loading

Uh oh!

Check notice

Copilot Autofix

Check warning

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Uh oh!

@@ -176,15 +176,8 @@
                 });
               }, [search, displayTree]);
-              const flatList = useMemo(() => {
-                if (!displayTree) return [];
-                // If display root is a directory, list its children instead of the directory itself (hide intermediate root)
-                if (displayTree.type === 'dir') {
-                  return displayTree.entries.flatMap(child => flattenNodes(child, [], 0));
-                }
-                return flattenNodes(displayTree, [], 0);
-              }, [displayTree, flattenNodes]);
               // Build hierarchical visible list honoring expandedPaths and optional sorting
               const sortedFlatList = useMemo(() => {
                 if (!displayTree) return [];

adding hub-sync feature code #873

Are you sure you want to change the base?

adding hub-sync feature code #873

Uh oh!

Conversation

jefeish commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Check notice

Uh oh!

Copilot Autofix

Check warning

Uh oh!

Copilot Autofix

Check notice

Uh oh!

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Uh oh!

jefeish commented Aug 28, 2025 •

edited

Loading