Skip to content

Fix file name could not be searched if the file was not a text file when using the Bleve indexer #33959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2025
Merged

Fix file name could not be searched if the file was not a text file when using the Bleve indexer #33959

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d2007e
Fix file name could not be searched if the file was not a text file w…
charles7668 Mar 21, 2025
6cefb0e
Update modules/indexer/code/bleve/bleve.go
charles7668 Mar 21, 2025
485e0c9
Merge branch 'main' into fix/search-by-filename
GiteaBot Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/indexer/code/bleve/bleve.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,8 @@ func (b *Indexer) addUpdate(ctx context.Context, batchWriter git.WriteCloserErro
return err
} else if !typesniffer.DetectContentType(fileContents).IsText() {
// FIXME: UTF-16 files will probably fail here
return nil
// Even if the file is not recognized as a "text file", we could still put its name into the indexers to make the filename become searchable, while leave the content to empty.
fileContents = nil
}

if _, err = batchReader.Discard(1); err != nil {
Expand Down