fix: add author.name field to Swift Package Registry API response #35410
+89
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes go-gitea#35159 Swift Package Manager expects an 'author.name' field in package metadata, but Gitea was only providing schema.org format fields (givenName, middleName, familyName). This caused SPM to fail with keyNotFound error when fetching package metadata. Changes: - Add 'name' field to Person struct (inherited from schema.org Thing) - Populate 'name' field in API response using existing String() method - Maintains backward compatibility with existing schema.org fields - Provides both formats for maximum compatibility The fix ensures Swift Package Manager can successfully resolve packages while preserving full schema.org compliance.
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/api
|
Maybe add some tests here ? |
techknowlogick
added
type/bug
backport/v1.24
|
It seems this only resolves the issue when retrieving package information, but not when uploading a package. |
@lunny before I finalize the fix, I want to clarify the intended behavior for the Should it be:
Which approach aligns better with Gitea's design? |
I guess the design could be this one? As long as end users can provide the "name" field, then use the value provided by them. |
ahanoff
force-pushed
the
fix/swift-package-registry-author-name
branch
from
3cb1899 to
ae68917
Compare
wxiaoguang
reviewed
Sep 6, 2025
wxiaoguang
approved these changes
Sep 6, 2025
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Sep 7, 2025
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Sep 7, 2025
…-gitea#35410) Fixes go-gitea#35159 Swift Package Manager expects an 'author.name' field in package metadata, but Gitea was only providing schema.org format fields (givenName, middleName, familyName). This caused SPM to fail with keyNotFound error when fetching package metadata. Changes: - Add 'name' field to Person struct (inherited from https://schema.org/Thing) - Populate 'name' field in API response using existing String() method - Maintains backward compatibility with existing schema.org fields - Provides both formats for maximum compatibility The fix ensures Swift Package Manager can successfully resolve packages while preserving full schema.org compliance.
GiteaBot
added
backport/done
wxiaoguang
pushed a commit
that referenced
this pull request
Sep 7, 2025
…5410) (#35431) Backport #35410 by ahanoff Fixes #35159 Swift Package Manager expects an 'author.name' field in package metadata, but Gitea was only providing schema.org format fields (givenName, middleName, familyName). This caused SPM to fail with keyNotFound error when fetching package metadata. Changes: - Add 'name' field to Person struct (inherited from https://schema.org/Thing) - Populate 'name' field in API response using existing String() method - Maintains backward compatibility with existing schema.org fields - Provides both formats for maximum compatibility The fix ensures Swift Package Manager can successfully resolve packages while preserving full schema.org compliance. Co-authored-by: Akhan Zhakiyanov <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 8, 2025
* giteaofficial/main: fix: add author.name field to Swift Package Registry API response (go-gitea#35410) Update js dependencies (go-gitea#35429) Support Node.js 22.6 with type stripping (go-gitea#35427) [skip ci] Updated translations via Crowdin apply as maintainer (go-gitea#35424) Upgrade golang to 1.25.1 and add descriptions for the swagger structs' fields (go-gitea#35418) Migrate tools and configs to typescript, require node.js >= 22.18.0 (go-gitea#35421) [skip ci] Updated translations via Crowdin Switch to `@resvg/resvg-wasm` for `generate-images` (go-gitea#35415) fix(webhook/discord): fixed username cannot be empty error (go-gitea#35412) add `/.pnpm-store` to .gitignore (go-gitea#35414)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35159
Swift Package Manager expects an 'author.name' field in package metadata, but Gitea was only providing schema.org format fields (givenName, middleName, familyName). This caused SPM to fail with keyNotFound error when fetching package metadata.
Changes:
The fix ensures Swift Package Manager can successfully resolve packages while preserving full schema.org compliance.