Skip to content

fix: prevent keyboard events during IME composition #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent keyboard events during IME composition #1535

wants to merge 1 commit into from

Conversation

maggch97
Copy link
Contributor

fix: #1531

kolaente
kolaente approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@kolaente kolaente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kolaente kolaente enabled auto-merge (squash) September 22, 2025 13:17
@kolaente
Copy link
Member

Seems like some frontend tests are now failing, please check if that's an issue with cypress or with your changes.

@kolaente kolaente disabled auto-merge September 22, 2025 13:58
@maggch97
Copy link
Contributor Author

I need to verify the test some days later. Currently I only have a arm mac, even run amd64 docker, npm run test:e2e still failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolaente kolaente kolaente approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enter as done shortcut is conflict with CJK input method
2 participants
@maggch97 @kolaente