Skip to content

Conversation

lemoer
Copy link
Contributor

@lemoer lemoer commented Jun 26, 2025

The executor itself does not set a session cookie, but requires one to be set before it works. This took me days to figure out, so maybe this will be helpful to somebody in the future.


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

The executor itself does not set a session cookie, but requires
one to be set before. This took me days to figure out, so maybe
this will be helpful to somebody in the future.

Signed-off-by: Leonardo Mörlein <[email protected]>
@lemoer lemoer requested a review from a team as a code owner June 26, 2025 00:47
Copy link

netlify bot commented Jun 26, 2025

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 821db43
🔍 Latest deploy log https://app.netlify.com/projects/authentik-docs/deploys/685d5d056c118800085986ed
😎 Deploy Preview https://deploy-preview-15252--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jun 26, 2025

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 821db43
🔍 Latest deploy log https://app.netlify.com/projects/authentik-storybook/deploys/685d5d0573c566000842dc92
😎 Deploy Preview https://deploy-preview-15252--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jun 26, 2025

Deploy Preview for authentik-integrations ready!

Name Link
🔨 Latest commit 821db43
🔍 Latest deploy log https://app.netlify.com/projects/authentik-integrations/deploys/685d5d0575a68b0008f68c31
😎 Deploy Preview https://deploy-preview-15252--authentik-integrations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@dewi-tik dewi-tik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion @lemoer

@dewi-tik dewi-tik enabled auto-merge (squash) June 26, 2025 14:45
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.05%. Comparing base (816d966) to head (821db43).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15252      +/-   ##
==========================================
+ Coverage   92.79%   93.05%   +0.25%     
==========================================
  Files         824      824              
  Lines       42685    42685              
==========================================
+ Hits        39611    39719     +108     
+ Misses       3074     2966     -108     
Flag Coverage Δ
e2e 47.61% <ø> (+0.71%) ⬆️
integration 24.22% <ø> (+<0.01%) ⬆️
unit 91.02% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @lemoer for adding this important detail!

@dewi-tik dewi-tik self-requested a review June 26, 2025 15:34
@dewi-tik dewi-tik dismissed their stale review June 26, 2025 15:35

Applied changes

@dewi-tik dewi-tik merged commit a957768 into goauthentik:main Jun 26, 2025
151 of 153 checks passed
@lemoer
Copy link
Contributor Author

lemoer commented Jul 17, 2025

It turns out that this only seems to work if the user is an admin user. Does someone have another idea how I can exchange a JWT into an http session cookie?

@tanberry
Copy link
Contributor

It turns out that this only seems to work if the user is an admin user. Does someone have another idea how I can exchange a JWT into an http session cookie?

@lemoer do we need to add a note to this doc to state that, that it only applies to Admins? As for your questions about converting a JWT, you could also ask that over on Discord.

@lemoer
Copy link
Contributor Author

lemoer commented Jul 23, 2025

@tanberry Thank you. I asked in the Discord and was advised to create a bug report, which I did in #15747. If this really turns out to be a bug and the bug is fixed, I think, we can remove the documentation hint again, which we added in this PR. Then it would have turned out, that this was only a work around for the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants