-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
website/docs: add hint that flows need cookies #15252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The executor itself does not set a session cookie, but requires one to be set before. This took me days to figure out, so maybe this will be helpful to somebody in the future. Signed-off-by: Leonardo Mörlein <[email protected]>
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion @lemoer
Signed-off-by: Dewi Roberts <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15252 +/- ##
==========================================
+ Coverage 92.79% 93.05% +0.25%
==========================================
Files 824 824
Lines 42685 42685
==========================================
+ Hits 39611 39719 +108
+ Misses 3074 2966 -108
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @lemoer for adding this important detail!
It turns out that this only seems to work if the user is an admin user. Does someone have another idea how I can exchange a JWT into an http session cookie? |
@lemoer do we need to add a note to this doc to state that, that it only applies to Admins? As for your questions about converting a JWT, you could also ask that over on Discord. |
@tanberry Thank you. I asked in the Discord and was advised to create a bug report, which I did in #15747. If this really turns out to be a bug and the bug is fixed, I think, we can remove the documentation hint again, which we added in this PR. Then it would have turned out, that this was only a work around for the bug. |
The executor itself does not set a session cookie, but requires one to be set before it works. This took me days to figure out, so maybe this will be helpful to somebody in the future.
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)