-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
web: Fix docs links, a11y input descriptors #16671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@@ -52,7 +52,7 @@ | |||
} | |||
|
|||
.pf-c-form__label[aria-required] .pf-c-form__label-text::after { | |||
content: "*"; | |||
content: "*" / "Required"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL
https://a11ysupport.io/tests/tech__css__css_generated_content_alt
Found this while debugging links using macOS's VoiceOver
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16671 +/- ##
==========================================
- Coverage 92.77% 92.77% -0.01%
==========================================
Files 838 838
Lines 45374 45374
==========================================
- Hits 42096 42095 -1
- Misses 3278 3279 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4d18682
to
2bfc025
Compare
<a class="pf-u-mb-xl" href=${url} ${external ? 'target="_blank"' : ""}> | ||
${external |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed issue where Lit escapes the attribute + moving out of render function to avoid redeclaring each time
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-f060627b5e72e5d9b292dd120a45db0cf868d0b8
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s Afterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-f060627b5e72e5d9b292dd120a45db0cf868d0b8 Afterwards, run the upgrade commands from the latest release notes. |
export function readGitBuildHash() { | ||
try { | ||
const commit = execSync("git rev-parse HEAD", { | ||
encoding: "utf8", | ||
cwd: MonoRepoRoot, | ||
}) | ||
.toString() | ||
.trim(); | ||
|
||
return commit; | ||
} catch (_error) { | ||
console.debug("Git commit could not be read."); | ||
} | ||
|
||
return process.env.GIT_BUILD_HASH || ""; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vestigial function, removed
.bighelp=${html`<p class="pf-c-form__helper-text"> | ||
${msg( | ||
html` A valid OCI manifest URL, prefixed with the protocol | ||
e.g. <code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some words such as e.g.
seem to have a special effect on VoiceOver and are automatically substituted for a phrase:
"e.g. foo, bar, baz." -> "Such as, foo, bar, baz."
Maybe we can put together a list as they're discovered?
b915c38
to
bc91ff0
Compare
@@ -11,7 +11,7 @@ import { html } from "lit"; | |||
|
|||
const sampleItems: FooterLink[] = [ | |||
{ name: "authentik", href: "https://goauthentik.io" }, | |||
{ name: "authentik docs", href: "https://docs.goauthentik.io/docs/" }, | |||
{ name: "authentik docs", href: "https://docs.goauthentik.io" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoiding usage of import.meta.env
here since the element test doesn't use the same bundle config.
if (prerelease) { | ||
ReleaseNotesURL = new URL("/releases", PreReleaseDocsURL); | ||
} else { | ||
ReleaseNotesURL = new URL(`releases/${VersionPath}`, CurrentReleaseDocsURL); | ||
|
||
return [AuthentikVersion, GIT_BUILD_HASH].join("+"); | ||
ReleaseNotesURL.hash = `fixed-in-${[major, minor, patch].join("")}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might be able to make this anchor less fragile with a generic #latest-release-notes
link in the docs.
cea1b24
to
15d903b
Compare
15d903b
to
f060627
Compare
Details
This PR fixes a collection of issues that prevent doc links from using the correct domain while developing authentik. Following up on #15774, this PR also unifies a several related behaviors surrounding URL constants.
1. Version Constants
We've gradually moved runtime constants into the build step. The fixes in this PR are focused on
web/packages/core/version/node.js
, moving much of error-prone version string splitting into a parsed object.2. Documentation links
Links to the docs are now injected during build time, fixing a few sources of URL mismatches such as when...
Additionally, some doc links have depended on redirects -- They've since been updated to match their current canonical URLs.
3. Miscellaneous
*
being read as asterisk instead of required