Properly specify the STATIC_CRT libgit2 flag
#285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libgit2 CMake configuration uses a custom flag `STATIC_CRT` and not the new CMake policy CMP0091. When forcing the CMake policy (as we do in our cmake tool), we need to also set the custom `STATIC_CRT` to avoid compiler warning about the /MD and /MT flag being overridden.
akien-mga
changed the title
STATIC_CRT libgit2 flag
akien-mga
approved these changes
May 27, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libgit2 CMake configuration uses a custom flag
STATIC_CRTand not the new CMake policy CMP0091.When forcing the CMake policy (as we do in our cmake tool), we need to also set the custom
STATIC_CRTto avoid compiler warning about the /MD and /MT flag being overridden.This was probably set to
0because the old godot cpp used /MD by default.Follow up on #199 (comment)