Skip to content

Conversation

RobJellinghaus
Copy link

Rust 1.89 added a new lifetime-related warning:
https://blog.rust-lang.org/2025/08/07/Rust-1.89.0/#mismatched-lifetime-syntaxes-lint

The Rust code generator currently emits code which trips this warning. This very small PR fixes the issue for the relevant generated functions and for the Rust flexbuffers code.

Fixes #8705

Tested as follows:

  • make -j
  • goldens/generate_goldens.py
  • cd tests
  • ./RustTest.sh

Rust 1.89 added a new lifetime-related warning:
<https://blog.rust-lang.org/2025/08/07/Rust-1.89.0/#mismatched-lifetime-syntaxes-lint>

The Rust code generator currently emits code which trips this warning. This very small PR
fixes the issue for the relevant generated functions and for the Rust flexbuffers code.

Fixes google#8705
Copy link

google-cla bot commented Sep 24, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added c++ codegen Involving generating code from schema rust labels Sep 24, 2025
@RobJellinghaus
Copy link
Author

RobJellinghaus commented Sep 24, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

I completed the form immediately before submitting the PR, using my [email protected] email address associated with the commit. So hopefully that will propagate naturally to satisfy this check.

Edit: the check is now satisfied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ codegen Involving generating code from schema rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rust] flatbuffers Rust codegen trips new lifetime lint in Rust 1.89
1 participant