gcc 4.7.2, 4.8.3, 4.9.2 unit test failures on C++11

[pshahid]

Hi, I've encountered some issues with the demangle unit tests using glog-0.3.4 on the gcc family of compilers. This is being run on fedora 20, with the compilers as seen in the title, and with C++11.

What follows is the last 30ish lines from the make/make check output.

gcc 4.7.2

./src/logging_striplog_test.sh
In DBG mode; not checking strings
PASS
./demangle_unittest  # force to create lt-demangle_unittest
./src/demangle_unittest.sh
Mangled symbols (14 out of 801) found in demangle.dm:
_ZN9__gnu_cxx13new_allocatorIPN6google7LogSinkEE9constructIS3_JRKS3_EEEvPT_DpOT0_
_ZN9__gnu_cxx13new_allocatorISsE9constructISsJRKSsEEEvPT_DpOT0_
_ZN9__gnu_cxx13new_allocatorISsE9constructISsJSsEEEvPT_DpOT0_
_ZNSt16allocator_traitsISaIPN6google7LogSinkEEE12_S_constructIS2_JRKS2_EEENSt9enable_ifIXsrNS4_18__construct_helperIT_JDpT0_EEE5valueEvE4typeERS3_PSA_DpOSB_
_ZNSt16allocator_traitsISaIPN6google7LogSinkEEE9constructIS2_JRKS2_EEEvRS3_PT_DpOT0_
_ZNSt16allocator_traitsISaISsEE12_S_constructISsJRKSsEEENSt9enable_ifIXsrNS1_18__construct_helperIT_JDpT0_EEE5valueEvE4typeERS0_PS7_DpOS8_
_ZNSt16allocator_traitsISaISsEE12_S_constructISsJSsEEENSt9enable_ifIXsrNS1_18__construct_helperIT_JDpT0_EEE5valueEvE4typeERS0_PS5_DpOS6_
_ZNSt16allocator_traitsISaISsEE9constructISsJRKSsEEEvRS0_PT_DpOT0_
_ZNSt16allocator_traitsISaISsEE9constructISsJSsEEEvRS0_PT_DpOT0_
_ZNSt6vectorIPN6google7LogSinkESaIS2_EE19_M_emplace_back_auxIJRKS2_EEEvDpOT_
_ZNSt6vectorISsSaISsEE12emplace_backIJSsEEEvDpOT_
_ZNSt6vectorISsSaISsEE19_M_emplace_back_auxIJRKSsEEEvDpOT_
_ZNSt6vectorISsSaISsEE19_M_emplace_back_auxIJSsEEEvDpOT_
_ZSt10_ConstructISsJSsEEvPT_DpOT0_
Mangled symbols (14 out of 801) found in demangle.dm

gcc 4.8.3

./src/demangle_unittest.sh
Mangled symbols (17 out of 800) found in demangle.dm:
_ZN9__gnu_cxx13new_allocatorIPN6google7LogSinkEE9constructIS3_JRKS3_EEEvPT_DpOT0_
_ZN9__gnu_cxx13new_allocatorISsE9constructISsJRKSsEEEvPT_DpOT0_
_ZN9__gnu_cxx13new_allocatorISsE9constructISsJSsEEEvPT_DpOT0_
_ZNSt16allocator_traitsISaIPN6google7LogSinkEEE12_S_constructIS2_JRKS2_EEENSt9enable_ifIXsrNS4_18__construct_helperIT_JDpT0_EEE5valueEvE4typeERS3_PSA_DpOSB_
_ZNSt16allocator_traitsISaIPN6google7LogSinkEEE9constructIS2_IRKS2_EEEDTcl12_S_constructfp_fp0_spcl7forwardIT0_Efp1_EEERS3_PT_DpOS8_
_ZNSt16allocator_traitsISaIPN6google7LogSinkEEE9constructIS2_JRKS2_EEEDTcl12_S_constructfp_fp0_spcl7forwardIT0_Efp1_EEERS3_PT_DpOS8_
_ZNSt16allocator_traitsISaISsEE12_S_constructISsJRKSsEEENSt9enable_ifIXsrNS1_18__construct_helperIT_JDpT0_EEE5valueEvE4typeERS0_PS7_DpOS8_
_ZNSt16allocator_traitsISaISsEE12_S_constructISsJSsEEENSt9enable_ifIXsrNS1_18__construct_helperIT_JDpT0_EEE5valueEvE4typeERS0_PS5_DpOS6_
_ZNSt16allocator_traitsISaISsEE9constructISsIRKSsEEEDTcl12_S_constructfp_fp0_spcl7forwardIT0_Efp1_EEERS0_PT_DpOS5_
_ZNSt16allocator_traitsISaISsEE9constructISsISsEEEDTcl12_S_constructfp_fp0_spcl7forwardIT0_Efp1_EEERS0_PT_DpOS3_
_ZNSt16allocator_traitsISaISsEE9constructISsJRKSsEEEDTcl12_S_constructfp_fp0_spcl7forwardIT0_Efp1_EEERS0_PT_DpOS5_
_ZNSt16allocator_traitsISaISsEE9constructISsJSsEEEDTcl12_S_constructfp_fp0_spcl7forwardIT0_Efp1_EEERS0_PT_DpOS3_
_ZNSt6vectorIPN6google7LogSinkESaIS2_EE19_M_emplace_back_auxIJRKS2_EEEvDpOT_
_ZNSt6vectorISsSaISsEE12emplace_backIJSsEEEvDpOT_
_ZNSt6vectorISsSaISsEE19_M_emplace_back_auxIJRKSsEEEvDpOT_
_ZNSt6vectorISsSaISsEE19_M_emplace_back_auxIJSsEEEvDpOT_
_ZSt10_ConstructISsJSsEEvPT_DpOT0_
Mangled symbols (17 out of 800) found in demangle.dm

gcc 4.9.2

./src/demangle_unittest.sh
Mangled symbols (20 out of 799) found in demangle.dm:
_ZN9__gnu_cxx13new_allocatorIPN6google7LogSinkEE9constructIS3_JRKS3_EEEvPT_DpOT0_
_ZN9__gnu_cxx13new_allocatorISsE9constructISsJRKSsEEEvPT_DpOT0_
_ZN9__gnu_cxx13new_allocatorISsE9constructISsJSsEEEvPT_DpOT0_
_ZNSt16allocator_traitsISaIPN6google7LogSinkEEE10_S_destroyIS2_EENSt9enable_ifIXsrSt6__and_IJNS4_16__destroy_helperIT_E4typeEEE5valueEvE4typeERS3_PS9_
_ZNSt16allocator_traitsISaIPN6google7LogSinkEEE12_S_constructIS2_JRKS2_EEENSt9enable_ifIXsrSt6__and_IJNS4_18__construct_helperIT_JDpT0_EE4typeEEE5valueEvE4typeERS3_PSB_DpOSC_
_ZNSt16allocator_traitsISaIPN6google7LogSinkEEE9constructIS2_IRKS2_EEEDTcl12_S_constructfp_fp0_spcl7forwardIT0_Efp1_EEERS3_PT_DpOS8_
_ZNSt16allocator_traitsISaIPN6google7LogSinkEEE9constructIS2_JRKS2_EEEDTcl12_S_constructfp_fp0_spcl7forwardIT0_Efp1_EEERS3_PT_DpOS8_
_ZNSt16allocator_traitsISaISsEE10_S_destroyISsEENSt9enable_ifIXsrSt6__and_IJNS1_16__destroy_helperIT_E4typeEEE5valueEvE4typeERS0_PS6_
_ZNSt16allocator_traitsISaISsEE12_S_constructISsJRKSsEEENSt9enable_ifIXsrSt6__and_IJNS1_18__construct_helperIT_JDpT0_EE4typeEEE5valueEvE4typeERS0_PS8_DpOS9_
_ZNSt16allocator_traitsISaISsEE12_S_constructISsJSsEEENSt9enable_ifIXsrSt6__and_IJNS1_18__construct_helperIT_JDpT0_EE4typeEEE5valueEvE4typeERS0_PS6_DpOS7_
_ZNSt16allocator_traitsISaISsEE9constructISsIRKSsEEEDTcl12_S_constructfp_fp0_spcl7forwardIT0_Efp1_EEERS0_PT_DpOS5_
_ZNSt16allocator_traitsISaISsEE9constructISsISsEEEDTcl12_S_constructfp_fp0_spcl7forwardIT0_Efp1_EEERS0_PT_DpOS3_
_ZNSt16allocator_traitsISaISsEE9constructISsJRKSsEEEDTcl12_S_constructfp_fp0_spcl7forwardIT0_Efp1_EEERS0_PT_DpOS5_
_ZNSt16allocator_traitsISaISsEE9constructISsJSsEEEDTcl12_S_constructfp_fp0_spcl7forwardIT0_Efp1_EEERS0_PT_DpOS3_
_ZNSt6vectorIPN6google7LogSinkESaIS2_EE19_M_emplace_back_auxIJRKS2_EEEvDpOT_
_ZNSt6vectorISsSaISsEE12emplace_backIJSsEEEvDpOT_
_ZNSt6vectorISsSaISsEE19_M_emplace_back_auxIJRKSsEEEvDpOT_
_ZNSt6vectorISsSaISsEE19_M_emplace_back_auxIJSsEEEvDpOT_
_ZSt10_ConstructIPN6google7LogSinkEJS2_EEvPT_DpOT0_
_ZSt10_ConstructISsJSsEEvPT_DpOT0_
Mangled symbols (20 out of 799) found in demangle.dm

[sergiud]

Is this still an issue?

[NeroBurner]

Still an issue on Ubuntu 14.04 compiled with GFLAGS (system package libgflags-dev/trusty,now 2.0-1.1ubuntu1), cmake and C++11

g++ (Ubuntu 4.8.4-2ubuntu1~14.04.4) 4.8.4

No issue on Ubuntu 14.04 compiled WITHOUT GFLAGS, cmake and C++11
https://travis-ci.org/NeroBurner/glog/jobs/394031958

No Issue on Ubuntu 18.04 compiled with GFLAGS (system package libgflags-dev/now 2.2.1-1), cmake and C++11

g++ (Ubuntu 7.3.0-16ubuntu3) 7.3.0

edit: compiled master abce788

cmake: renamed GFLAGS_NAMESPACE to GLOG_GFLAGS_NAMESPACE (#318)