This repository was archived by the owner on Jun 30, 2025. It is now read-only.
src/logging.cc: encapsulate log cleaner, match logfile with <base_filename_><date>-<time>.<pid> #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aesophor
changed the title
aesophor
force-pushed
the
encapsulate-log-cleaner
branch
from
1b56ad7 to
7764e4a
Compare
|
@cswuyg Could you please review the changes? |
|
@sergiud I've been using this patch in my own projects for a week and it seems to work well. Tested on both Linux and Windows. |
|
Please don't merge it yet, I've found a potential bug: Currently I'm checking if a file is a glog's logfile by checking if its filename starts with base_filename_, but this might also delete non-glog logfiles. I should make sure the entire filename matches the format of a glog's filename. |
aesophor
force-pushed
the
encapsulate-log-cleaner
branch
from
b27370a to
36fa99b
Compare
aesophor
changed the title
|
@sergiud I've revised the patch and re-tested it. |
|
Please resolve the conflict. |
Closed
|
@sergiud I've resolved the conflict. Thanks! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously log cleaner could be broken if users use
SetLogDestination()to set a custombase_filename_, as discussed here: #432 (comment)This PR fixes this bug by checking if a log's filename starts with
base_filename_.