-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Adds fuzz testing for demangle #878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review. I have a couple of remarks that need to be addressed.
@sergiud I pushed fixes for your review :-) |
friendly ping @sergiud ;-) |
Thanks for the ping @catenacyber. I'm very sorry for the delay. I will look into PR during the coming week. Please stay tuned. |
Ideally, we would run fuzzing as part of our Github workflow. What do we need for that? |
3 steps :
|
@sergiud I hope I got cmake right ;-) |
@catenacyber Almost there. Another question: glog will be moving to C++14 shortly. Anything that we need to consider here? |
I do not see why c++14 would be a problem. |
OK, great! One more thing: once you are done with the last change, please also rebase onto current master and squash if possible. |
Done ;-) |
Codecov Report
@@ Coverage Diff @@
## master #878 +/- ##
==========================================
- Coverage 73.94% 73.58% -0.37%
==========================================
Files 17 17
Lines 3282 3282
==========================================
- Hits 2427 2415 -12
- Misses 855 867 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Thanks! |
@sergiud here is a PR to get fuzzing built with cmake
cf google/oss-fuzz#9160 (comment)