This repository was archived by the owner on Jun 20, 2025. It is now read-only.
Ban setting special attributes #451
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents circumventing our checks by code like `<script
text="{$evil}">` or `<i innerHTML="{$evil}">` in Soy IDOM.
The newly added test is flaky. Any idea why?
|
Shouldn't the soy compiler be handling this? |
|
This seems like a better place. I see no point in abusing |
|
OK. I'm a bit apprehensive about landing a breaking change since people use Incremental DOM at HEAD. Do you mind moving this internally into google3 soy? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents circumventing our checks by code like
<script text="{$evil}">or<i innerHTML="{$evil}">in Soy IDOM.The newly added test is flaky. Any idea why?