leveldb exports symbols

[cmumford]

Original issue 1 created by abarth@chromium.org on 2011-04-20T00:00:16.000Z:

leveldb appears to export symbols. In Chrome, we don't want to export these symbols. In fact, we have a script that breaks the build whenever we export an unexpected symbol. Here's a patch that fixes the issue:

Index: util/env_chromium.cc
===================================================================
--- util/env_chromium.cc    (revision 21)
+++ util/env_chromium.cc    (working copy)
@@ -30,8 +30,9 @@
 #endif

 #if defined(OS_MACOSX) || defined(OS_WIN)
+namespace {
+
 // The following are glibc-specific
-extern "C" {
 size_t fread_unlocked(void *ptr, size_t size, size_t n, FILE *file) {
   return fread(ptr, size, n, file);
 }
@@ -51,6 +52,7 @@
   return fsync(fildes);
 #endif
 }
+
 }
 #endif

[cmumford]

Comment #1 originally posted by hans@chromium.org on 2011-04-20T12:44:18.000Z:

<empty>

[cmumford]

Comment #2 originally posted by hans@chromium.org on 2011-05-09T13:30:51.000Z:

This was fixed in http://code.google.com/p/leveldb/source/detail?r=26