Fixing build on windows with Visual Studio #4
Conversation
cmumford
force-pushed
the
master
branch
2 times, most recently
from
735fc09 to
803d692
Compare
|
Where can I find any instructions how to build leveldb with VS and/or MinGW? |
|
@chfast This is not an easy task. Here you can find bash script and instruction how to build LevelDB (use env_win.cc from bitcoin project) use MinGW for LevelDB JNA adapter for Java. |
|
@chfast You can also have a look at |
|
@ralphtheninja thanks for that, might be useful for me as I'm trying to get Python package working on Windows. Nevertheless, is leveldb interested in having basic Windows support? |
|
@chfast You could try to clone ENikS/leveldb or ENikS/bitcoin-dev-msvc to see how it is done in MS VS. It is not up to date but will give you enough to start |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
8d4eb08 Add HasAcceleratedCRC32C to port_win.h (Cory Fields) 77cfbfd crc32: move helper functions out of port_posix_sse.cc (Cory Fields) 4c1e9e0 silence compiler warnings about uninitialized variables (Cory Fields) Pull request description: Addresses google#4. As this file is compiled with sse42 flags, it's possible that the feature discovery ends up using an unsupported instruction at runtime. Fix this by adding CanAccelerateCRC32C to the port api, and requiring that it be checked before using AcceleratedCRC32C. Tree-SHA512: 166cc0f4758bc0f22adda2126acad83e0251605a3a14d695fbb34a1d40f2328c4d938fbdcd624964281e6b9fcb3b233d3a8bde010ab889d82ae4f94479c6e545
|
The current code builds on Windows, as tracked by AppVeyor. Going to close this. Sorry we weren't able to get to it earlier! |
Building project with Microsoft tools choke on this include file:<unistd.h>
It should be excluded when compiled with Visual Studio compiler on MS OS.