Skip to content

FakeStorageRpc/LocalStorageHelper: leads to logs about needing to call Builder#setApplicationName #1496

@glasser

Description

@glasser

Steps to reproduce

  1. Use LocalStorageHelper at all
  2. See log messages needing to call setApplicationName

Code example

Anything using LocalStorageHelper, eg

LocalStorageHelper.customOptions(true).getService().writer(...)

ends up running this code in FakeStorageRpc.java

  public com.google.api.services.storage.Storage getStorage() {
    HttpTransport transport = new FakeStorageRpcHttpTransport();
    HttpRequestInitializer httpRequestInitializer = request -> {};
    return new com.google.api.services.storage.Storage(
        transport, new GsonFactory(), httpRequestInitializer);
  }

This Storage constructor creates and then immediately uses a Storage.Builder, which means there's no place to call Builder#setApplicationName, leading to an unavoidable log.

Stack trace

The logged message is:

WARN  com.google.api.client.googleapis.services.AbstractGoogleClient  - Application name is not set. Call Builder#setApplicationName.

Metadata

Metadata

Assignees

Labels

api: storageIssues related to the googleapis/java-storage-nio API.priority: p3Desirable enhancement or fix. May not be included in next release.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions