-
Notifications
You must be signed in to change notification settings - Fork 44
feat(sb2xbp): add Scratch to XBP conversion functionality and related parameters #2118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces Scratch to XBP conversion functionality to the spx-backend service. It adds a new conversion endpoint that transforms Scratch project files (versions 2 and 3) into XBP format using the sb2xbp library.
- Adds core conversion logic in the sb2xbp package with type inference and configurable name mapping
- Implements a REST API endpoint (/scratch-convert) with authentication and input validation
- Includes dependency on the external goplus/sb2xbp library for the conversion functionality
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
spx-backend/internal/sb2xbp/sb2xbp.go | Core conversion logic that processes Scratch data and returns XBP format |
spx-backend/internal/controller/sb2xbp.go | Controller with parameter types, validation, and authenticated conversion handler |
spx-backend/go.mod | Dependency additions for sb2xbp conversion library and related packages |
spx-backend/cmd/spx-backend/post_scratch-convert.yap | REST endpoint implementation with authentication and JSON request handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…ams and adjust conversion logic
@go-wyvern: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.