Skip to content

Conversation

jacobcrawford
Copy link
Contributor

@jacobcrawford jacobcrawford commented Mar 14, 2025

What this PR does / why we need it:
The Loki Canary only worked when the gateway was enabled. We should support setting the Loki endpoint through values so it does not have as hard dependency to the gateway.

Which issue(s) this PR fixes:
Fixes #14233
Fixes #11208

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/helm type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Mar 14, 2025
@jacobcrawford jacobcrawford force-pushed the bugfix-canary-only-worked-when-gateway-enabled branch from fca1d8e to 7c00dd0 Compare March 14, 2025 10:44
@jacobcrawford jacobcrawford changed the title canary only worked when gateway enabled fix: canary only worked when gateway enabled Mar 14, 2025
@jacobcrawford jacobcrawford marked this pull request as ready for review March 14, 2025 10:46
@jacobcrawford jacobcrawford requested a review from a team as a code owner March 14, 2025 10:46
@jacobcrawford jacobcrawford requested a review from JStickler March 17, 2025 08:07
@jacobcrawford jacobcrawford force-pushed the bugfix-canary-only-worked-when-gateway-enabled branch from 7c00dd0 to a7be443 Compare April 17, 2025 05:27
@jacobcrawford
Copy link
Contributor Author

@JStickler is anything holding us back from completing this PR?

@jacobcrawford
Copy link
Contributor Author

@slim-bean or @knylander-grafana maybe one of you can review this super small PR. We are a company that would really appreciate being able to use the loki-canary deployment 😄

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@jacobcrawford
Copy link
Contributor Author

@slim-bean thank you for the review! 😄
Merging is blocked because im not authorized to push to your branch. Is the process normally that you merge the PR?
Or maybe the workflows also need to be approved by a maintainer?

@slim-bean
Copy link
Collaborator

yeah we have to restrict running workflows to be approved by maintainers and we are also the only folks with merge access.

I just kicked off CI will try to merge it as soon as it finishes!

@JStickler JStickler merged commit 45b2d49 into grafana:main Jun 2, 2025
75 checks passed
@jacobcrawford jacobcrawford deleted the bugfix-canary-only-worked-when-gateway-enabled branch June 24, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canary points to gateway when gateway is disabled. Loki Canary seems broken when gateway is disabled
4 participants