-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix: canary only worked when gateway enabled #16758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: canary only worked when gateway enabled #16758
Conversation
fca1d8e
to
7c00dd0
Compare
7c00dd0
to
a7be443
Compare
@JStickler is anything holding us back from completing this PR? |
@slim-bean or @knylander-grafana maybe one of you can review this super small PR. We are a company that would really appreciate being able to use the loki-canary deployment 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
@slim-bean thank you for the review! 😄 |
yeah we have to restrict running workflows to be approved by maintainers and we are also the only folks with merge access. I just kicked off CI will try to merge it as soon as it finishes! |
What this PR does / why we need it:
The Loki Canary only worked when the gateway was enabled. We should support setting the Loki endpoint through values so it does not have as hard dependency to the gateway.
Which issue(s) this PR fixes:
Fixes #14233
Fixes #11208
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR