-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix(helm): add livenessProbe to read pods in Simple Scalable mode #17063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): add livenessProbe to read pods in Simple Scalable mode #17063
Conversation
…t if unset or null, does not provoke any errors
e9a1758
to
d431034
Compare
Just rebased on top of |
d431034
to
139af1a
Compare
lint: amended the commit to run helm-docs |
139af1a
to
9746718
Compare
Rebased on top of |
ea3e463
to
b9b00ae
Compare
…t if unset or null, does not provoke any errors
b9b00ae
to
f813039
Compare
…ngerFromTheAbyss/loki into fix-read-liveness-probe
…iness instead of liveness
Missed the automatic weekly PR because of conflicts. Will fix them by next Monday before next weekly MR pickup |
Signed-off-by: someStrangerFromTheAbyss <[email protected]>
Hey @someStrangerFromTheAbyss, would you mind running: make helm-docs from the top of the loki directory this will deal with the failing documentation check |
@Jayclifford345 Will do right away |
Hi @someStrangerFromTheAbyss, I am just in the process of reviewing this PR, completely understandable you want to use a liveliness probe. Would you mind supplying the Loki values file you used to test this PR? I will have a quick spin myself and see if we can get this unstuck for you |
Its a big value file, but its a real one we use. OF course, credentials replace with FAKE. |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #15191
Special notes for your reviewer:
This mainly add livenessProbe for the read pod. This will maybe helm some issues with the read pods when deploying a loki in simple Scalable mode
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR