Skip to content

fix(helm): add livenessProbe to read pods in Simple Scalable mode #17063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 28, 2025
Merged

fix(helm): add livenessProbe to read pods in Simple Scalable mode #17063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8cf9fac
chore: adding livenessProbe to the read pods
someStrangerFromTheAbyss Apr 8, 2025
20aa051
fix: changed the inclusion of livenessProbe to be conditionnal so tha…
someStrangerFromTheAbyss Apr 8, 2025
e78c385
fix(doc): adding missing documentation with the make helm-docs
someStrangerFromTheAbyss Apr 8, 2025
f8a8f90
chore: adding livenessProbe to the read pods
someStrangerFromTheAbyss Apr 8, 2025
bf0aceb
fix: changed the inclusion of livenessProbe to be conditionnal so tha…
someStrangerFromTheAbyss Apr 8, 2025
f813039
fix(doc): adding missing documentation with the make helm-docs
someStrangerFromTheAbyss Apr 8, 2025
9ab0562
Merge branch 'fix-read-liveness-probe' of https://github.com/someStra…
someStrangerFromTheAbyss Apr 23, 2025
845f46b
fix(helm): reverted accidental change made on the deployment for read…
someStrangerFromTheAbyss Apr 23, 2025
23c0d17
Merge branch 'main' into fix-read-liveness-probe
someStrangerFromTheAbyss May 5, 2025
81f9b0d
Merge branch 'main' into fix-read-liveness-probe
benjaminlebigot May 6, 2025
2e157e3
Merge branch 'main' into fix-read-liveness-probe
someStrangerFromTheAbyss May 6, 2025
3952755
Merge branch 'main' into fix-read-liveness-probe
someStrangerFromTheAbyss May 8, 2025
82715a1
Merge branch 'main' into fix-read-liveness-probe
someStrangerFromTheAbyss May 12, 2025
3d7cc2d
Merge branch 'main' into fix-read-liveness-probe
someStrangerFromTheAbyss May 22, 2025
6325f18
Merge branch 'main' into fix-read-liveness-probe
someStrangerFromTheAbyss May 27, 2025
95c8d1b
fix(doc): regenerate doc
someStrangerFromTheAbyss May 27, 2025
62b0144
Merge branch 'main' into fix-read-liveness-probe
Jayclifford345 May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions docs/sources/setup/install/helm/reference.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9687,6 +9687,7 @@ false
},
"legacyReadTarget": false,
"lifecycle": {},
"livenessProbe": {},
"nodeSelector": {},
"persistence": {
"annotations": {},
Expand Down Expand Up @@ -9892,6 +9893,15 @@ false
<td><pre lang="json">
{}
</pre>
</td>
</tr>
<tr>
<td>read.livenessProbe</td>
<td>object</td>
<td>liveness probe settings for read pods. If empty, applies no livenessProbe</td>
<td><pre lang="json">
{}
</pre>
</td>
</tr>
<tr>
Expand Down
6 changes: 6 additions & 0 deletions production/helm/loki/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ Entries should include a reference to the pull request that introduced the chang

[//]: # (<AUTOMATED_UPDATES_LOCATOR> : do not remove this line. This locator is used by the CI pipeline to automatically create a changelog entry for each new Loki release. Add other chart versions and respective changelog entries bellow this line.)

## 6.30.1

- [BUGFIX] Add livenessProbe to read pod to go around the issue mentioned [here](https://github.com/grafana/loki/issues/15191#issuecomment-2769843275)

## 6.29.1

- [FEATURE] Added support for the rules sidecar in the ruler pods in distributed mode
- [BUGFIX] Ensure global.extraEnv and global.extraEnvFrom applied to all resources consistently ([#16828](https://github.com/grafana/loki/pull/16828))
- [BUGFIX] Fixed statement logic to enable annotations for deployment-gateway, deployment-read, and statefulset-write
Expand Down
2 changes: 1 addition & 1 deletion production/helm/loki/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: loki
description: Helm chart for Grafana Loki and Grafana Enterprise Logs supporting monolithic, simple scalable, and microservices modes.
type: application
appVersion: 3.5.0
version: 6.30.0
version: 6.30.1
home: https://grafana.github.io/helm-charts
sources:
- https://github.com/grafana/loki
Expand Down
2 changes: 1 addition & 1 deletion production/helm/loki/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# loki

![Version: 6.30.0](https://img.shields.io/badge/Version-6.30.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 3.5.0](https://img.shields.io/badge/AppVersion-3.5.0-informational?style=flat-square)
![Version: 6.30.1](https://img.shields.io/badge/Version-6.30.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 3.5.0](https://img.shields.io/badge/AppVersion-3.5.0-informational?style=flat-square)

Helm chart for Grafana Loki and Grafana Enterprise Logs supporting monolithic, simple scalable, and microservices modes.

Expand Down
4 changes: 4 additions & 0 deletions production/helm/loki/templates/read/deployment-read.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@ spec:
{{- toYaml .Values.loki.containerSecurityContext | nindent 12 }}
readinessProbe:
{{- toYaml .Values.loki.readinessProbe | nindent 12 }}
{{- if .Values.read.livenessProbe }}
livenessProbe:
{{- toYaml .Values.read.livenessProbe | nindent 12 }}
{{- end }}
volumeMounts:
- name: config
mountPath: /etc/loki/config
Expand Down
4 changes: 4 additions & 0 deletions production/helm/loki/templates/read/statefulset-read.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,10 @@ spec:
{{- toYaml .Values.loki.containerSecurityContext | nindent 12 }}
readinessProbe:
{{- toYaml .Values.loki.readinessProbe | nindent 12 }}
{{- if .Values.read.livenessProbe }}
livenessProbe:
{{- toYaml .Values.read.livenessProbe | nindent 12 }}
{{- end }}
{{- with .Values.read.lifecycle }}
lifecycle:
{{- toYaml . | nindent 12 }}
Expand Down
2 changes: 2 additions & 0 deletions production/helm/loki/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1639,6 +1639,8 @@ read:
extraVolumes: []
# -- Resource requests and limits for the read
resources: {}
# -- liveness probe settings for read pods. If empty, applies no livenessProbe
livenessProbe: {}
# -- Grace period to allow the read to shutdown before it is killed
terminationGracePeriodSeconds: 30
# -- Affinity for read pods.
Expand Down
Loading