Skip to content

Conversation

xperimental
Copy link
Collaborator

What this PR does / why we need it:

We recently changed our tooling that we use for building Loki. The new tool validates that the vendoring is "consistent" by running go mod vendor again and then committing everything (ignoring the ignore). This uncovered that there are a few files missing from the vendor directory because they are ignored in the .gitignore.

I don't think this is intentional, so this PR removes the lines from the ignores. I have also run go mod vendor again to add the missing files to the vendor directory.

Which issue(s) this PR fixes:

Special notes for your reviewer:

  • An alternative would be to add ignores that just match the workspace files in the top-level (which might have been the original intention).

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Title matches the required conventional commits format, see here

@xperimental xperimental requested a review from a team as a code owner April 15, 2025 11:48
@xperimental xperimental changed the title fix(deps): Remove workspace file from ignore and regenerate vendor fix(deps): Remove workspace files from ignore and regenerate vendor Apr 15, 2025
@xperimental xperimental merged commit 8e0325e into grafana:main May 20, 2025
65 checks passed
@xperimental xperimental deleted the fix-ignore-work branch May 20, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants