Skip to content

fix(helm): Correct typo in reference to global values. #17472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(helm): Correct typo in reference to global values. #17472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions production/helm/loki/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Entries should include a reference to the pull request that introduced the chang

[//]: # (<AUTOMATED_UPDATES_LOCATOR> : do not remove this line. This locator is used by the CI pipeline to automatically create a changelog entry for each new Loki release. Add other chart versions and respective changelog entries bellow this line.)

- [BUGFIX] Fixed mismatch in reference to global value `extraEnvFrom` in Helm chart.
- [FEATURE] Added support for the rules sidecar in the ruler pods in distributed mode

## 6.29.0
Expand Down
2 changes: 1 addition & 1 deletion production/helm/loki/templates/backend/statefulset-backend.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ spec:
env:
{{- toYaml . | nindent 12 }}
{{- end }}
{{- with (concat .Values.global.extraEnv .Values.backend.extraEnvFrom) | uniq }}
{{- with (concat .Values.global.extraEnvFrom .Values.backend.extraEnvFrom) | uniq }}
envFrom:
{{- toYaml . | nindent 12 }}
{{- end }}
Expand Down