Skip to content

chore(engine): print stringified planning durations #19155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

chore(engine): print stringified planning durations #19155

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
794969a
chore(engine): print stringified physical planning duration
rfratto Sep 10, 2025
a8eb1f2
chore(engine): print stringified logical planning duration
rfratto Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/engine/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ func (e *QueryEngine) Execute(ctx context.Context, params logql.Params) (logqlmo
level.Info(logger).Log(
"msg", "finished logical planning",
"plan", logicalPlan.String(),
"duration", durLogicalPlanning.Seconds(),
"duration", durLogicalPlanning.String(),
)
span.SetStatus(codes.Ok, "")
return logicalPlan, nil
Expand Down Expand Up @@ -173,7 +173,7 @@ func (e *QueryEngine) Execute(ctx context.Context, params logql.Params) (logqlmo
level.Info(logger).Log(
"msg", "finished physical planning",
"plan", physical.PrintAsTree(plan),
"duration", durPhysicalPlanning.Seconds(),
"duration", durPhysicalPlanning.String(),
)
span.SetStatus(codes.Ok, "")
return plan, nil
Expand Down
Loading