-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix(helm): bump rollout-operator chart to v0.33.1 #19176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the need for new CRDs or upgrading CRDs needs more attension.
|
||
## Unreleased | ||
|
||
- [ENHANCEMENT] Upgrade rollout-operator to [v0.33.1](https://github.com/grafana/helm-charts/releases/tag/rollout-operator-0.33.1). Note: [Action required](https://github.com/grafana/helm-charts/tree/main/charts/rollout-operator#upgrade-of-grafana-rollout-operator) when upgrading. [#19176](https://github.com/grafana/loki/pull/19176) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marshallford Do I understand, that the version have new CRDs on board? Could you assist here with an upgrade guide? Helm does not handle the updates of CRDs.
Based on that @JStickler or @Jayclifford345 could write a detailed upgrade guide for such changes.
I feel it better, if there is TL;DR: Command to execute, not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right that helm upgrade
won’t handle newly introduced CRDs -- users who upgrade to this version will need to apply those CRDs manually. That said, this change won’t affect most users immediately: the Loki chart does not yet make use of these new CRDs, so no action is required until they are actually referenced.
Some GitOps tools (e.g. Flux HelmReleases) provide their own mechanisms for managing CRDs, but in general this is outside Helm’s native behavior.
Long story short: I’m happy to expand the changelog note if that helps, though I’d lean towards keeping detailed upgrade instructions in the rollout-operator documentation rather than duplicating them across all dependent charts.
What this PR does / why we need it:
As per title, bumps rollout-operator chart to v0.33.1 for Loki. Similar PR for Mimir: grafana/mimir#12591
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
I'd imagine a follow-on refactor is needed for this change to be useful out of the box. Additional values/templating could be added for
deploymentMode: Distributed
to better utilize the rollout-operator's annotations/labels now that the rollout-operator helm chart supports the webhook,ReplicaTemplate
CR, etc. Similar PR for Mimir: grafana/mimir#6733Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR