depends: add cross arm64-darwin support #2775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamescowens What are we building bzip2 in depends for? |
div72
force-pushed
the
arm64-darwin-cross
branch
2 times, most recently
from
03618ae to
cbba203
Compare
|
Probably nothing. I think it came along for the ride with the original depends port.Sent from my iPhoneOn Sep 15, 2024, at 8:05 PM, div72 ***@***.***> wrote:
@jamescowens What are we building bzip2 in depends for?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
div72
force-pushed
the
arm64-darwin-cross
branch
from
0db7cbe to
b04bd2a
Compare
jamescowens
reviewed
Sep 23, 2024
See bitcoin/bitcoin#22380. GNU flavor is used for the C standard as OpenSSL have troubles building without it.
Needed for cross arm64-apple-darwin builds.
Needed now since FORCE_USE_SYSTEM_CLANG is removed and system clang is mandatory.
See bitcoin/bitcoin#7f5ac4520d1553170b1053a9ffcd58179386a6d2.
Fixes an issue with Clang 18.
Needed for recognizing the `arm64-apple-darwin` triplet.
Needed since the current version cannot parse the `arm64-apple-darwin` triplet.
Allows upgrading libzip. Adding CMake as a dependency is inevitable as both upstream and Qt6 uses CMake as their build system.
The configure in the tarball does not recognize `arm64-apple-darwin`, re-generation fixes that.
div72
force-pushed
the
arm64-darwin-cross
branch
from
b04bd2a to
d046727
Compare
|
Just rebased, all green now. |
jamescowens
added a commit
that referenced
this pull request
Feb 16, 2025
Added - depends: add cross arm64-darwin support #2775 (@div72) - build: add missing randomness checks #2772 (@div72) - init, registry: Support -clearallregistryhistory startup parameter #2773 (@jamescowens) Changed - build: omit _FORTIFY_SOURCE on debug #2793 (@div72) - doc: cmake is required for Windows depends #2791 (@barton2526) - CMake: Set maximum supported Boost version #2788 (@CyberTailor) - ci: bump to MacOS 13 #2784 (@div72) - build/cmake: disable LevelDB tests #2776 (@div72) - util: use XDG_STATE_HOME for datadir on Flatpak #2774 (@div72) - util, build: Support miniupnp API version 18+ #2771 (@jamescowens) - build: explicitly include FindPkgConfig for CMake #2769 (@jamescowens) - ci, cd: bump action versions #2763 (@div72) - Sync CMake CI #2762 (@CyberTailor) - cpid: Modify CPID local hasher to eliminate compiler warnings on 32 bit archs #2760 (@jamescowens) Removed - refactor, misc: remove CBitcoin(Address|Secret) #2634 (@div72) Fixed - poll, gui: Disable choice add button in poll wizard when choice limit is reached #2792 (@jamescowens) - diagnose, rpc: fix compilation with boost 1.87 #2786 (@div72) - node: fix build with GCC 15 #2783 (@CyberTailor) - ci: use overwrite with brew install on MacOS CMake #2782 (@div72) - scraper: Protect access to ConvergedStats.csv.gz with a lock #2779 (@jamescowens) - fix build on FreeBSD #2770 (@wilkart) - rpc/server: fix removing deprecated commands from command list #2768 (@lrusak) - cmake bdb53: disable error for implicit-int with gcc #2767 (@lrusak)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds arm64-darwin support for depends. Also removes the LLVM toolchain from the depends, a recent version of clang is now required for MacOS cross builds.
Updates libzip to 1.10.1. CMake is now required for depends. bzip2 is removed from depends.
CD output tested on a M1 Mac, starts without an issue.