nomad: specify namespace when querying group #808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Nomad Autoscaler agent can only target a single namespace, but when using the wildcard (`*`) value it is possible to monitor policies for all namespaces. With this configuration, the Nomad APM plugin must specify the job namespace when querying for information as the agent is configured with the wildcard.
lgfa29
commented
Dec 21, 2023
Comment on lines
-111
to
+118
| c.Query = fmt.Sprintf("%s_%s/%s/%s", | ||
| nomadAPM.QueryTypeTaskGroup, c.Query, t.Config[sdk.TargetConfigKeyTaskGroup], t.Config[sdk.TargetConfigKeyJob]) | ||
| c.Query = fmt.Sprintf( | ||
| "%s_%s/%s/%s@%s", | ||
| nomadAPM.QueryTypeTaskGroup, | ||
| c.Query, | ||
| t.Config[sdk.TargetConfigKeyTaskGroup], | ||
| t.Config[sdk.TargetConfigKeyJob], | ||
| t.Config[sdk.TargetConfigKeyNamespace], | ||
| ) |
There was a problem hiding this comment.
This is an internal query format, so I wouldn't consider it a breaking change.
Co-authored-by: James Rasell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Nomad Autoscaler agent can only target a single namespace, but when using the wildcard (
*) value it is possible to monitor policies for all namespaces.With this configuration, the Nomad APM plugin must specify the job namespace when querying for information as the agent is configured with the wildcard.
Ref: #65 (comment)