Add the ability to ignore unhandled critical certificate exceptions #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomcf-hcp
reviewed
Aug 5, 2024
sgmiller
added a commit
that referenced
this pull request
Aug 5, 2024
…313) * Wire up support for ignoring unhandled critical extensions * update deps * update dep * Peg to real tag * attempts at testing * Support the cert pool * setup the CA roots in the roundtripper if present * remove dead code
sgmiller
added a commit
that referenced
this pull request
Aug 5, 2024
…313) * Wire up support for ignoring unhandled critical extensions * update deps * update dep * Peg to real tag * attempts at testing * Support the cert pool * setup the CA roots in the roundtripper if present * remove dead code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some customers have complex PKI setups that include certificate extensions
marked "critical" that the Go TLS stack doesn't understand. When it
encounters such an extension, it fails TLS validation.
This PR adds an option to the JWT auth method,
unsupported_critical_cert_extensions, which can be set to a commaseparated list of the OIDs of extensions that should be ignored.