Add limitMaybe_, offsetMaybe_ + tests #633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tathougies
reviewed
Mar 3, 2022
|
I'm sorry @thomasjm, I wasn't able to figure out what's missing to make the types fit. I'm not super familiar with this mechanism. Good news is that since you have tests, I'm not worried about merging this PR. Would you mind adding a comment near the uses of |
thomasjm
force-pushed
the
limit-offset-maybe
branch
from
dc6d15e to
deb5d2d
Compare
|
Thanks @LaurentRDC -- just added those comments and rebased on |
|
Thanks! |
|
I should be able to make a new release today |
|
Released in |
|
Thank you! I was just working on another one I was hoping you could take a look at: #534 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heard there was a major release cycle coming :).
This would resolve #491.
Note: I used an
unsafeCoerceto implement these. I think it's fine and the tests pass, but maybe there's a nicer way to wrangle the types here?