Fix test_lazy_choices_help failure on Python 3.14+ #1643
+21
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python started raise early errors for invalid help strings, effectively triggering our LazyChoices action to query the options when added. By using a custom ArgumentParser subclass that disables this check, LazyChoices works as intended. Note that in real httpie code, all argument parsing is done via BaseHTTPieArgumentParser subclasses, so this fixes the problem in httpie as well as in the tests. Directly using BaseHTTPieArgumentParser in test_lazy_choices_help is not trivial, as it would require more setup. Fixes httpie#1641
|
Python 3.7 CI is failing because that Python is no longer available. |
|
test_cli_utils.py seems to pass. All the other failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python started raise early errors for invalid help strings, effectively triggering our LazyChoices action to query the options when added.
By using a custom ArgumentParser subclass that disables this check, LazyChoices works as intended.
Note that in real httpie code,
all argument parsing is done via BaseHTTPieArgumentParser subclasses, so this fixes the problem in httpie as well as in the tests.
Directly using BaseHTTPieArgumentParser in test_lazy_choices_help is not trivial, as it would require more setup.
Fixes #1641