Skip to content

Lower complexity of get_balanced_memory by adding a set #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2025
Merged

Lower complexity of get_balanced_memory by adding a set #3776

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f47f73b
Lower complexity by adding a set
SamuelBarryCS Sep 12, 2025
33d8af9
Push vibe coded eval script
SamuelBarryCS Sep 12, 2025
4a19d5c
Clean
SamuelBarryCS Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/accelerate/utils/modeling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,7 +1041,8 @@ def get_balanced_memory(

# Compute mean of final modules. In the first dict of module sizes, leaves are the parameters
leaves = get_module_leaves(module_sizes)
module_sizes = {n: v for n, v in module_sizes.items() if n not in leaves}
leaves_set = set(leaves) # Convert to set for O(1) membership testing
module_sizes = {n: v for n, v in module_sizes.items() if n not in leaves_set}
# Once removed, leaves are the final modules.
leaves = get_module_leaves(module_sizes)
mean_leaves = int(sum([module_sizes[n] for n in leaves]) / max(len(leaves), 1))
Expand Down
Loading