Fix: ignore precompute_ref_log_probs when use_liger_loss=True #4008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Problem: When
use_liger_loss=True
andprecompute_ref_log_probs=True
, the trainer still computes and attaches unused reference log probability columns (ref_chosen_logps, ref_rejected_logps). This results in unnecessary overhead.Solution: Force-disable
args.precompute_ref_log_probs
(set to False) whenuse_liger_loss=True
, and emit a warning log to inform the user.Impact: Limited to the DPOTrainer initialization path for the Liger loss setting. The change is backward compatible and does not affect other training modes.
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.