Skip to content

Conversation

sangwaboi
Copy link

This PR adds support for Apple Silicon (M1/M2/M3) Macs by:

  • Updating Dockerfiles to use python:3.8-slim base image for better ARM64 compatibility
  • Adding build dependencies for gevent and other packages
  • Pinning gevent to version 22.10.2 for Python 3.8 compatibility
  • Updating docker-compose.dev.yml to use named volumes instead of host mounts
  • Fixing platform-specific build issues for ARM64 architecture

Changes have been tested on:

  • M3 Pro Macbook Pro (ARM64)
  • Verified backward compatibility with existing AMD64 setup

Key improvements:

  1. Platform Detection: Improved detection of architecture for Docker builds
  2. Multi-arch Support: Using python:3.8-slim for ARM64 and AMD64
  3. Backward Compatibility: Maintained support for AMD64 users
  4. Performance: Enabled native ARM64 builds on Apple Silicon without emulation

Done/Closes #681

@sangwaboi
Copy link
Author

@YoungHypo
Could you please review this PR? It implements Apple Silicon support as discussed in #681. The changes have been tested on M3 Pro and maintain backward compatibility with AMD64 as well.

Key points for review:

  1. Dockerfile changes for ARM64 compatibility
  2. Volume handling in docker-compose
  3. Build dependency updates

@yeasy
Copy link
Contributor

yeasy commented May 27, 2025

To make the CI happen, please help sign-off the commit following https://github.com/hyperledger-cello/cello/wiki/Contribution-Process.

…RM64, fix build dependencies, use named volumes

Signed-off-by: Vishvendra <[email protected]>
@sangwaboi sangwaboi force-pushed the feat/apple-silicon-support branch from 7c6e7de to e5c2779 Compare May 27, 2025 19:25
@sangwaboi
Copy link
Author

@yeasy, I've addressed the DCO requirements. The PR is now compliant with the Hyperledger contribution process. Thank you for the guidance!

@yeasy yeasy requested a review from YoungHypo May 29, 2025 20:53
@sangwaboi
Copy link
Author

@YoungHypo could you please review this PR ..

@sangwaboi sangwaboi force-pushed the feat/apple-silicon-support branch from a9536ff to 50b7c0b Compare June 10, 2025 05:06
Vishvendra added 2 commits June 10, 2025 10:44
…lity - Fix code formatting issues and implement invoke endpoint

Signed-off-by: Vishvendra <[email protected]>
@sangwaboi sangwaboi force-pushed the feat/apple-silicon-support branch from 50b7c0b to e09ae57 Compare June 10, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add macOS Apple Silicon (M1/M2/M3) Support
2 participants