Use 3-arg form of open in LoadFile #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ingydotnet#120 Otherwise `$filename = ">file.yaml"; LoadFile($filename)` will truncate a file. One should check untrusted filenames in any case, though.
ingydotnet
approved these changes
Jan 29, 2025
shlomif
reviewed
Feb 7, 2025
briandfoy
added a commit
to briandfoy/cpan-security-advisory
that referenced
this pull request
May 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120
Otherwise
$filename = ">file.yaml"; LoadFile($filename)will truncate a file.One should check untrusted filenames in any case, though.