Skip to content

make react-native-windows peer dependency optional #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2021
Merged

make react-native-windows peer dependency optional #1016

merged 1 commit into from
Nov 4, 2021

Conversation

mjgallag
Copy link
Contributor

@mjgallag mjgallag commented Jun 4, 2021

As of npm v7, peerDependencies are installed by default.
https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependencies

@arcollector
Copy link

please merge!

@jspizziri
Copy link

jspizziri commented Sep 3, 2021 •
edited
Loading

@itinance , any chance of this getting merged? It's making it impossible to install this package when using npm >= 7 and not deploying to Windows (which is IMHO the most common use-case).

@jspizziri
Copy link

@itinance 🥺 🙏

@itinance itinance merged commit 087db72 into itinance:master Nov 4, 2021
@itinance
Copy link
Owner

itinance commented Nov 4, 2021

thanks guys!

@arcollector
Copy link

please updated npm version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjgallag @arcollector @jspizziri @itinance