Skip to content

Conversation

DiscowZombie
Copy link
Contributor

@DiscowZombie DiscowZombie commented Jun 15, 2022

Added support for Pufferfish 1.19

Compilation & execution have been tested.

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this. Can you see if that suggestion works?

@itzg
Copy link
Owner

itzg commented Jun 15, 2022

I think this will help with #1556

@DiscowZombie
Copy link
Contributor Author

The code now uses the versionLessThan function and has been tested with both 1.17, 1.18 and 1.19 !

@DiscowZombie DiscowZombie requested a review from itzg June 16, 2022 17:11
Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry I gave you the suggestion logic inverted.

@itzg itzg merged commit 23c8fc6 into itzg:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants