Add GraalVM CE support #1601
Merged
Add GraalVM CE support #1601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzg
reviewed
Jul 16, 2022
There was a problem hiding this comment.
Awesome! Works great. If you could add the two new line items to https://github.com/itzg/docker-minecraft-server#running-minecraft-server-on-different-java-version then this is ready to merge.
|
@itzg Just did it! |
|
@itzg Hmm... seems like we have to delete check for ZSTD for Oracle Linux 8-based images. tar on OL8 seems like it can't handle zstd. Works on my production OL9 funnily. |
|
Weird, the PR testing build should have flagged that. I/you can use the "require" mechanism to skip that test for graal builds. |
|
...ah, PR build only considers the "latest" base image. The build-time trade off is awkward with PR builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, GraalVM EE needs complex setup to build (you need to register to Oracle Container Registry and log in) so only CE for now. Build tested.
RELATED: #1252