Skip to content

Conversation

WugWugg
Copy link
Contributor

@WugWugg WugWugg commented Aug 21, 2022

Sorry to do this to you ITZG, but I realized the previous pull request wasn't complete. I got it working this time. Promise :)

@WugWugg
Copy link
Contributor Author

WugWugg commented Aug 21, 2022

Accept incoming changes and all should be good

@itzg
Copy link
Owner

itzg commented Aug 21, 2022

No problem at all! I have had plenty of commit-fixes myself 😊

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.

@@ -1,5 +1,23 @@
#!/bin/bash

function get_from_gh() {
Copy link
Owner

@itzg itzg Aug 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be really cool to later port this over to

https://github.com/itzg/mc-image-helper/blob/master/src/main/java/me/itzg/helpers/get/GetCommand.java

and/or a verify-gh-scope subcommand.

@itzg itzg merged commit 4f81047 into itzg:master Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants