Cleanup discord release message #2532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I'm testing some thing. Doesn't look like I can put it in draft. Don't complete this just yet. |
|
I reverted my test and will use another branch for testing. Sorry, I forgot it would impact this PR. |
No problem at all. I'll squash and merge at the end FWIW |
|
I have a PR in the Action's repo to make improvements on it. Hopefully they respond. In the mean time, this can go as is. |
itzg
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I played w/ a few actions and github-releases-to-discord looked the cleanest to me and has a couple other options if wanted. The only downside I saw was it doesn't cleanup HTML comments in the Release Body. So when making a release it would be recommended to manually delete the HTML comment the "Generate release notes" button adds. In the mean time, I'm going to submit an Issue/PR to that action to accommodate that scenario.