Allow Remote Console to be Enabled #2576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This enables the work that was started in the mc-server-runner pull request to add a remote SSH console.
itzg/mc-server-runner#56
ENABLE_SSHsettingValidation Performed
Built the docker container locally on an ARM64 system (M1 Mac mini with an Ubuntu VM running docker). Started a (Fabric) server with ENABLE_SSH set and the 2222 port exposed. Was able to login from a standard ssh client and issue commands to it. Docker logs were checked and confirmed that the output was sent to both locations and I could audit SSH connections.
Discovered that the default password of 'minecraft' is never usable with the container due to the configuration scripts generating a scrambled password when RCON_PASSWORD is not defined.
Checked to ensure that the server still works when ENABLE_SSH is not defined, and logs behave as expected.