-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Ignoring particular
#3437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignoring particular
#3437
Conversation
I'm not sure why you're submitting a PR when you suspect the exclusion doesn't work. The file is considered equally along with using the CF_EXCLUDE_MODS env var. So if the var doesn't work the file update wont either. |
Maybe my configuration is wrong. But the crash is caused by particular. |
Sure but why are you creating a PR for an issue you haven't resolved yet? Are you guessing/hoping this is the solution? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regardless of my comments, I'm good to add this since https://www.curseforge.com/minecraft/mc-mods/particular does indeed look like it should be flagged as client only.
@itzg I just notice that : I think that I'using the newer version, and maybe ignoring the older one ? |
Yes, that will be it then. The exclusion can only exactly match the identifier. Otherwise for all the code knows it is a completely different mod. You can submit a new PR to add that one too. |
What's strange is that they said that after 1.20.1 the mod is require on server but with it my server is crashing |
Also, if we check the server files provided with the modpack and see that this particular mod is missing, does that mean they gave false information on their page? That’s strange — I need to test this. Sorry for the confusion. Sometimes I don’t take the time to do things thoroughly and end up rushing too much. |
@itzg So, particular-reforged is required on server before version 1.20.1. Then we cannot ignore particular-reforged everywhere. |
The best so far is excluding per modpack. Of course individual users are also able to add exclusions as needed to their particular container. Sounds like this is one that might have to fall into the last case, which is unfortunate. |
That's totally fine. I appreciate your enthusiasm and ongoing research on this. |
Related to #3436