Skip to content

Conversation

enzofrnt
Copy link
Contributor

@enzofrnt enzofrnt commented May 5, 2025

Related to #3436

@itzg
Copy link
Owner

itzg commented May 5, 2025

I'm not sure why you're submitting a PR when you suspect the exclusion doesn't work. The file is considered equally along with using the CF_EXCLUDE_MODS env var. So if the var doesn't work the file update wont either.

@enzofrnt
Copy link
Contributor Author

enzofrnt commented May 5, 2025

Maybe my configuration is wrong. But the crash is caused by particular.

@itzg
Copy link
Owner

itzg commented May 5, 2025

Sure but why are you creating a PR for an issue you haven't resolved yet? Are you guessing/hoping this is the solution?

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regardless of my comments, I'm good to add this since https://www.curseforge.com/minecraft/mc-mods/particular does indeed look like it should be flagged as client only.

@itzg itzg merged commit 9d749ab into itzg:master May 5, 2025
1 check passed
@enzofrnt
Copy link
Contributor Author

enzofrnt commented May 5, 2025

@itzg I just notice that :
https://www.curseforge.com/minecraft/mc-mods/particular-reforged

I think that I'using the newer version, and maybe ignoring the older one ?

@itzg
Copy link
Owner

itzg commented May 5, 2025

Yes, that will be it then. The exclusion can only exactly match the identifier. Otherwise for all the code knows it is a completely different mod.

You can submit a new PR to add that one too.

@enzofrnt
Copy link
Contributor Author

enzofrnt commented May 5, 2025

What's strange is that they said that after 1.20.1 the mod is require on server but with it my server is crashing

@enzofrnt
Copy link
Contributor Author

enzofrnt commented May 5, 2025

Also, if we check the server files provided with the modpack and see that this particular mod is missing, does that mean they gave false information on their page? That’s strange — I need to test this. Sorry for the confusion.

Sometimes I don’t take the time to do things thoroughly and end up rushing too much.

@enzofrnt
Copy link
Contributor Author

enzofrnt commented May 5, 2025

@itzg So, particular-reforged is required on server before version 1.20.1. Then we cannot ignore particular-reforged everywhere.
But maybe, somewhere in the documentation, we can list by version of modpack the needed exclusion ?

@itzg
Copy link
Owner

itzg commented May 5, 2025

The best so far is excluding per modpack. Of course individual users are also able to add exclusions as needed to their particular container. Sounds like this is one that might have to fall into the last case, which is unfortunate.

@itzg
Copy link
Owner

itzg commented May 5, 2025

Sorry for the confusion.

Sometimes I don’t take the time to do things thoroughly and end up rushing too much.

That's totally fine. I appreciate your enthusiasm and ongoing research on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants