Skip to content

Conversation

hyiltiz
Copy link
Contributor

@hyiltiz hyiltiz commented Feb 16, 2024

Removes friction from PR contributions and automatically triggers the linters/checks without first getting "approval" from repo maintainer.

@hyiltiz
Copy link
Contributor Author

hyiltiz commented Feb 16, 2024

@pepe provided review to this change in #172.

Copy link
Member

@pepe pepe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@bakpakin bakpakin merged commit 86bab58 into janet-lang:master Feb 16, 2024
@hyiltiz hyiltiz deleted the github-workflow-PR-no-click-required branch February 19, 2024 17:02
@sogaiu
Copy link
Contributor

sogaiu commented Aug 16, 2025

For future reference, there is an analysis of what this change might have resulted in here.

The SO answer linked to might be worth digesting as there appear to be security implications as well.

A few interesting links turned up in the process of examining the answer:

I'm sorry to have not understood the change appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants